Repository navigation
Make workspace typecheck green and gate it in CI - #42
Merged
Merged
Conversation
Fix residual @prm/api TypeScript errors (ReviewDTO mapping, logActivity null ids, director briefing narrowing, P1 assignmentFor helper) and run `pnpm -r typecheck` before tests on every PR to main. Co-authored-by: Damon <[email protected]>
Co-authored-by: Damon <[email protected]>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe change adds recursive workspace typechecking to CI and contributor guidance. It also tightens API typing for review mapping, bundle generation, route assignment, and nullable activity logging. ChangesTypecheck and API contracts
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm -r typecheckwas still failing on@prm/api(called out in AGENTS). For a public merge bar that is unacceptable.Changes
logActivitynull entity ids, director briefing narrowing, and P1assignmentFortypingpnpm -r typecheckto CI beforepnpm testTest plan
pnpm -r typecheckpassespnpm test(73 pass)Summary by CodeRabbit
Quality Improvements
Reliability